Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass resolved config to rollup:before hook #1160

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This allows modifying the resolved rollup config.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Apr 17, 2023

This looks good but can you please also explain the usecase for this extend?

@danielroe
Copy link
Member Author

I have no specific current use case but in past I've had to work around this because otherwise there is no hook or way to update the generated rollup config.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1160 (064b57b) into main (490f0ab) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   67.90%   67.77%   -0.13%     
==========================================
  Files          66       66              
  Lines        6486     6486              
  Branches      719      716       -3     
==========================================
- Hits         4404     4396       -8     
- Misses       2067     2075       +8     
  Partials       15       15              
Impacted Files Coverage Ξ”
src/build.ts 42.85% <100.00%> (ΓΈ)
src/rollup/config.ts 87.99% <100.00%> (-0.44%) ⬇️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 48a979e into main Apr 18, 2023
@pi0 pi0 deleted the feat/rollup-config-hook branch April 18, 2023 08:00
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants