Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config reload support for nitro dev #1173

Merged
merged 8 commits into from
Apr 19, 2023
Merged

feat: config reload support for nitro dev #1173

merged 8 commits into from
Apr 19, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 19, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Using new c12.watchConfig to watch nitro configuration and auto-reload.

Note: This only enables watch for nitro dev and not external frameworks like Nuxt. Nuxt CLI should adopt c12 watcher itself.

Note: This PR also unlocks HMR support for nitro πŸš€

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1173 (14eef49) into main (3313207) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 14eef49 differs from pull request most recent head 5b0f11a. Consider uploading reports for the commit 5b0f11a to get more accurate results

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   76.78%   76.83%   +0.04%     
==========================================
  Files          67       67              
  Lines        6501     6514      +13     
  Branches      690      691       +1     
==========================================
+ Hits         4992     5005      +13     
  Misses       1508     1508              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/nitro.ts 89.42% <100.00%> (+0.31%) ⬆️
src/options.ts 96.18% <100.00%> (+0.08%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 marked this pull request as ready for review April 19, 2023 17:50
@pi0 pi0 merged commit 5c92dc3 into main Apr 19, 2023
@pi0 pi0 deleted the feat/dev-reload branch April 19, 2023 17:50
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant