Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: export defineNitroConfig from nitro/config #1174

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Apr 19, 2023

  • perf: export defineNitroConfig from nitropack/config
  • update usages

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

By importing defineNuxtConfig from nitro/config subpath, startup time significantly reduces as JITI does not need to load whole nitro and it's deps as CJS

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Apr 19, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview c8e5efb

@pi0 pi0 merged commit 3313207 into main Apr 19, 2023
@pi0 pi0 deleted the perf/define-config branch April 19, 2023 17:25
@pi0 pi0 mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant