Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerenderer): don't inherit static config #1324

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Without this, if we pass static: true in initial config we will be unable to prerender anything.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 20, 2023
@danielroe danielroe requested a review from pi0 June 20, 2023 12:57
@danielroe danielroe self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1324 (c688763) into main (9bb674f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
- Coverage   76.22%   76.21%   -0.02%     
==========================================
  Files          68       68              
  Lines        6953     6949       -4     
  Branches      684      686       +2     
==========================================
- Hits         5300     5296       -4     
  Misses       1652     1652              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/prerender.ts 89.53% <100.00%> (-0.13%) ⬇️

@pi0 pi0 changed the title fix: don't inherit static config for prerenderer fix(prerenderer): don't inherit static config Jun 20, 2023
@pi0 pi0 merged commit 0ffab31 into main Jun 20, 2023
7 checks passed
@pi0 pi0 deleted the fix/force-non-static-prerenderer branch June 20, 2023 13:03
@pi0
Copy link
Member

pi0 commented Jun 20, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants