Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add envPrefix to runtimeConfig.nitro types #1336

Merged
merged 2 commits into from
Jun 22, 2023
Merged

fix: add envPrefix to runtimeConfig.nitro types #1336

merged 2 commits into from
Jun 22, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 22, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a missing type for runtimeConfig.nitro - apologies!

(This is not a blocker for Nuxt.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 22, 2023
@danielroe danielroe requested a review from pi0 June 22, 2023 10:52
@danielroe danielroe self-assigned this Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1336 (18ec7bb) into main (21a2595) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   76.67%   76.67%           
=======================================
  Files          70       70           
  Lines        7160     7161    +1     
  Branches      710      710           
=======================================
+ Hits         5490     5491    +1     
  Misses       1669     1669           
  Partials        1        1           
Impacted Files Coverage Ξ”
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

@pi0 pi0 changed the title fix: add envPrefix to runtimeConfig.nitro namespace fix: add envPrefix to runtimeConfig.nitro types Jun 22, 2023
@pi0 pi0 merged commit ed69bae into main Jun 22, 2023
7 checks passed
@pi0 pi0 deleted the fix/env-prefix branch June 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants