Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): default target to static when static override is set #1342

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#21728

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If we have enabled static then we should default to static preset rather than node-server. As we are only using detectTarget in these two places, I think we can also slightly simplify the code.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 23, 2023
@danielroe danielroe requested a review from pi0 June 23, 2023 22:10
@danielroe danielroe self-assigned this Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1342 (c4ad939) into main (e77e0ed) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1342   +/-   ##
=======================================
  Coverage   76.68%   76.68%           
=======================================
  Files          70       70           
  Lines        7162     7162           
  Branches      710      710           
=======================================
  Hits         5492     5492           
  Misses       1669     1669           
  Partials        1        1           
Impacted Files Coverage Ξ”
src/options.ts 94.44% <50.00%> (ΓΈ)
src/utils/index.ts 74.02% <50.00%> (ΓΈ)

@pi0 pi0 changed the title fix: default to static rather than node-server if static is set fix(options): default target to static when static override is set Jun 26, 2023
@pi0 pi0 merged commit 966ac34 into main Jun 26, 2023
6 of 7 checks passed
@pi0 pi0 deleted the fix/default-static-target branch June 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants