Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): enable allowSyntheticDefaultImports option by default #1383

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix(types): enable allowSyntheticDefaultImports option by default #1383

merged 1 commit into from
Jul 3, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This enables allowSyntheticDefaultImports: true by default.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 3, 2023
@danielroe danielroe self-assigned this Jul 3, 2023
@pi0 pi0 changed the title fix: allow synthetic default imports feat: enable allowSyntheticDefaultImports typescript option by default Jul 3, 2023
@pi0
Copy link
Member

pi0 commented Jul 3, 2023

I think it is a nice default. Is there any known issue that this fixes?

@pi0 pi0 changed the title feat: enable allowSyntheticDefaultImports typescript option by default feat(types): enable allowSyntheticDefaultImports option by default Jul 3, 2023
@danielroe Volta.net
Copy link
Member Author

It fixes the issue of not having TS/IDE support when importing modules with synthetic default imports into a server route. Someone encountered this on Twitter.

@pi0 pi0 changed the title feat(types): enable allowSyntheticDefaultImports option by default fix(types): enable allowSyntheticDefaultImports option by default Jul 3, 2023
@pi0 pi0 merged commit 49fff5b into main Jul 3, 2023
5 checks passed
@pi0 pi0 deleted the fix/resolution branch July 3, 2023 19:20
@pi0 pi0 mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0