Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add custom preset instructions #1409

Merged
merged 6 commits into from
Jul 14, 2023
Merged

docs: add custom preset instructions #1409

merged 6 commits into from
Jul 14, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jul 9, 2023

πŸ”— Linked issue

Resolves #1373

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds some instructions about custom presets.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #1409 (7913e74) into main (6bc50b2) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
- Coverage   76.73%   76.68%   -0.06%     
==========================================
  Files          71       71              
  Lines        7273     7273              
  Branches      727      726       -1     
==========================================
- Hits         5581     5577       -4     
- Misses       1691     1694       +3     
- Partials        1        2       +1     

see 1 file with indirect coverage changes

@Hebilicious Hebilicious added documentation Improvements or additions to documentation preset ready labels Jul 9, 2023
@Hebilicious Hebilicious requested a review from pi0 July 9, 2023 07:54
@pi0
Copy link
Member

pi0 commented Jul 10, 2023

Starter is updated: https://github.com/unjs/nitro-preset-starter

As per discussion, we shall point the users from docs to this repo for having latest version in same place.

Copy link
Member Author

I've updated the PR with a link to the new starter

docs/content/2.deploy/3.custom-presets.md Outdated Show resolved Hide resolved
docs/content/2.deploy/3.custom-presets.md Outdated Show resolved Hide resolved
docs/content/2.deploy/3.custom-presets.md Outdated Show resolved Hide resolved
docs/content/2.deploy/3.custom-presets.md Outdated Show resolved Hide resolved
@pi0 pi0 merged commit 90503da into main Jul 14, 2023
4 of 5 checks passed
@pi0 pi0 deleted the custom-presets-docs branch July 14, 2023 09:06
@pi0
Copy link
Member

pi0 commented Jul 14, 2023

Thanks for helping on this ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation preset ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to make custom nitro presets
2 participants