Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ignore to ignore scanned files #1430

Merged
merged 2 commits into from
Jul 14, 2023
Merged

feat: support ignore to ignore scanned files #1430

merged 2 commits into from
Jul 14, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 14, 2023

πŸ”— Linked issue

Resolves #843

Related: nuxt/nuxt#13427, #945

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR supports ignore: string[] option in order to specify ignore patterns for scanning /plugins, /middleware, /routes and /api from all layers. The scan.ts has been almost rewritten to be prepared for this. Supporting public dir ignore in #945 after this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1430 (3ff5c47) into main (fd9a9ee) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   76.47%   76.77%   +0.30%     
==========================================
  Files          71       71              
  Lines        7323     7323              
  Branches      724      725       +1     
==========================================
+ Hits         5600     5622      +22     
+ Misses       1722     1699      -23     
- Partials        1        2       +1     
Impacted Files Coverage Ξ”
src/options.ts 94.87% <100.00%> (+0.01%) ⬆️
src/scan.ts 100.00% <100.00%> (ΓΈ)
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

... and 3 files with indirect coverage changes

@pi0 pi0 changed the title feat: support ignore to ignore scaned files feat: support ignore to ignore scanned files Jul 14, 2023
@pi0 pi0 merged commit a3bf7e3 into main Jul 14, 2023
7 checks passed
@pi0 pi0 deleted the feat/ignore branch July 14, 2023 13:43
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.nitroignore support
1 participant