fix(prerender): skip redirects #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1448 +/- ##
=======================================
Coverage 76.17% 76.17%
=======================================
Files 73 73
Lines 7437 7439 +2
Branches 728 728
=======================================
+ Hits 5665 5667 +2
Misses 1771 1771
Partials 1 1
|
pi0
reviewed
Jul 17, 2023
| if (res.status !== 200) { | ||
| // https://developer.mozilla.org/en-US/docs/Web/HTTP/Redirections | ||
| const redirectCodes = [301, 302, 303, 304, 307, 308]; | ||
| if (![200, ...redirectCodes].includes(res.status)) { |
There was a problem hiding this comment.
Maybe as a feature we can try to follow redirects by checking Location header?
There was a problem hiding this comment.
That would be nice yes. I think we can merge this and do it in a separated PR.
There was a problem hiding this comment.
If not too much trouble introducing in same would be nice (so final changelog wouln't be a fix+feat)
There was a problem hiding this comment.
/cc @Hebilicious are you still on this? Please let me know if needed help
There was a problem hiding this comment.
Haven't had the time to look, but I should have time to work on this in the upcoming days.
pi0
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Fix #1402
Resolves #1418
β Type of change
π Description
External links that returns 200 or 30x should be treated the same way.
We might need to add an additional check for external links.
π Checklist