Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add internal types for public assets #1460

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We had an untyped asset which can safely produce types for. This PR improves internal type safety but no bug or issue was encountered with the code.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1460 (070afad) into main (e87e2ba) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
- Coverage   76.17%   76.14%   -0.03%     
==========================================
  Files          73       73              
  Lines        7437     7428       -9     
  Branches      728      728              
==========================================
- Hits         5665     5656       -9     
  Misses       1771     1771              
  Partials        1        1              
Impacted Files Coverage Ξ”
src/rollup/plugins/public-assets.ts 92.68% <100.00%> (-0.50%) ⬇️

src/runtime/static.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: add types for public assets data refactor: add internal types for public assets Jul 19, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ’―

@pi0 pi0 merged commit 3687d31 into main Jul 19, 2023
7 checks passed
@pi0 pi0 deleted the fix/public-assets-type branch July 19, 2023 08:46
@pi0 pi0 mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants