Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prerender): only match href attribute after whitespace #1530

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #1527

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This restricts href regexp to match only href and not x-link:href (for example).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1530 (4a1bfbf) into main (451d314) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 4a1bfbf differs from pull request most recent head 5b3f217. Consider uploading reports for the commit 5b3f217 to get more accurate results

@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   76.25%   76.25%           
=======================================
  Files          73       73           
  Lines        7478     7478           
  Branches      734      734           
=======================================
  Hits         5702     5702           
  Misses       1775     1775           
  Partials        1        1           
Files Changed Coverage Ξ”
src/prerender.ts 87.07% <100.00%> (ΓΈ)

@Hebilicious Hebilicious added bug Something isn't working prerender labels Aug 4, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (added fixture too)

@pi0 pi0 merged commit 0486db8 into main Aug 6, 2023
4 of 5 checks passed
@pi0 pi0 deleted the fix/full-href branch August 6, 2023 18:40
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prerender
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xlink:href within SVG is crawled
4 participants