Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firebase): fix typos in warning message #1561

Merged
merged 1 commit into from
Aug 10, 2023
Merged

chore(firebase): fix typos in warning message #1561

merged 1 commit into from
Aug 10, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Aug 10, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1561 (ff65a2b) into main (8c0473c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1561   +/-   ##
=======================================
  Coverage   76.48%   76.48%           
=======================================
  Files          73       73           
  Lines        7579     7579           
  Branches      751      751           
=======================================
  Hits         5797     5797           
  Misses       1781     1781           
  Partials        1        1           
Files Changed Coverage Ξ”
src/presets/firebase.ts 21.36% <0.00%> (ΓΈ)

@pi0 pi0 changed the title chore: fix logger warning typo chore(firebase): fix typos in warning message Aug 10, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 576b920 into main Aug 10, 2023
8 of 9 checks passed
@pi0 pi0 deleted the firebase-typo branch August 10, 2023 17:35
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants