Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run tests even if not serveStatic #1590

Merged
merged 7 commits into from
Aug 16, 2023
Merged

test: run tests even if not serveStatic #1590

merged 7 commits into from
Aug 16, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I think we were skipping running some tests when we should have been running them. Might have missed some context here though.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1590 (ac6418d) into main (96cf2f8) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head ac6418d differs from pull request most recent head 9a21b69. Consider uploading reports for the commit 9a21b69 to get more accurate results

@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
- Coverage   76.26%   76.19%   -0.08%     
==========================================
  Files          76       76              
  Lines        7800     7800              
  Branches      781      780       -1     
==========================================
- Hits         5949     5943       -6     
- Misses       1849     1854       +5     
- Partials        2        3       +1     

see 3 files with indirect coverage changes

@pi0 pi0 merged commit ce5d223 into main Aug 16, 2023
7 checks passed
@pi0 pi0 deleted the test/skip-static branch August 16, 2023 11:55
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants