Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vercel,netlify): don't deprecate swr when cache: false #1603

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(vercel,netlify): don't deprecate swr when cache: false #1603

merged 1 commit into from
Aug 18, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#22699
resolves #1602

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Wrongly we were warning about legacy use of swr when cache: false.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 18, 2023
@danielroe danielroe requested a review from pi0 August 18, 2023 12:49
@danielroe danielroe self-assigned this Aug 18, 2023
pi0
pi0 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit d584781 into main Aug 18, 2023
7 checks passed
@pi0 pi0 deleted the fix/isr-warning branch August 18, 2023 12:54
@chris-visser
Copy link

That was fast !

@danielroe
Copy link
Member Author

appreciate the issue 😊

@pi0 pi0 mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected warning on Nitro preset "netlify" Unexpected warning on Nitro preset "netlify"
3 participants
@danielroe @chris-visser @pi0