Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(firebase): update generated package.json #1608

Merged
merged 5 commits into from
Aug 20, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 20, 2023

  • wip
  • update

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since the Nitro externals plugin is already fully aware of written dependencies, and with improvements in #1607, we can simply try to read the already written package.json and try to update it. (however, we might not the updates either in the future by adding main and engines fields by default to the generated package.json

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit e80752c into main Aug 20, 2023
5 of 6 checks passed
@pi0 pi0 deleted the fix/firebase-pkg branch August 20, 2023 21:38
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant