Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude typed body from cachedEventHandler #1647

Merged
merged 2 commits into from
Aug 26, 2023
Merged

fix: exclude typed body from cachedEventHandler #1647

merged 2 commits into from
Aug 26, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 26, 2023

πŸ”— Linked issue

#1640 (comment)

closes #1646

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Quick improvement iterating on #1640. This will need to be improved when we add validator inference to h3's event handler, and in future when headers might be added.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 26, 2023
@danielroe danielroe self-assigned this Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #1647 (6a6ddf2) into main (a0e60fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files          76       76           
  Lines        7824     7824           
  Branches      803      803           
=======================================
  Hits         6084     6084           
  Misses       1738     1738           
  Partials        2        2           

@danielroe danielroe marked this pull request as ready for review August 26, 2023 20:08
@danielroe danielroe requested a review from pi0 August 26, 2023 20:08
@pi0 pi0 merged commit b470fd0 into main Aug 26, 2023
8 of 9 checks passed
@pi0 pi0 deleted the fix/exclude-body branch August 26, 2023 20:23
@pi0
Copy link
Member

pi0 commented Aug 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

body type for cachedEventHandler should be never
2 participants