fix(azure): fix cookie format normalization

[tobiasdiez]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Cookies set by the users were dropped when the app is deployed to Azure. Reason is that azure expects the cookie to be of the form { name: 'key', value: 'val } but nitro was passing it in the form { key: 'val' }.
This is fixed, along with a few other improvements. (Refs #1452)

While working on this, I found a bug in the cookie parser: unjs/cookie-es#17

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

Merging #1753 (e289aba) into main (3f7faa5) will increase coverage by 0.13%.
The diff coverage is 92.72%.

❗ Current head e289aba differs from pull request most recent head 7662142. Consider uploading reports for the commit 7662142 to get more accurate results

@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   77.26%   77.39%   +0.13%     
==========================================
  Files          75       76       +1     
  Lines        7912     7976      +64     
  Branches      806      823      +17     
==========================================
+ Hits         6113     6173      +60     
- Misses       1797     1801       +4     
  Partials        2        2              

Files	Coverage Δ
src/runtime/utils.azure.ts	93.75% <92.72%> (ø)

[pi0]

Thanks for this nice PR and also unit tests 💯

I have added few refactors to have basic httponly/secure support, one typo in sameSite case and also more generic code style.

If something was bad, feel free to amend via a new PR.

[tobiasdiez]

Thanks @pi0, your changes are nice improvements!

Btw, I think it would make sense to put this cookie parsing actually in h3, and use it to internally store the cookies as nice typed objects. What happens right now if you set a cookie is the following: set cookie as object > serialize cookie to string > now here in the azure handler: parse cookie again to get it back as an object. This whole serialization and parsing business can be skipped for azure and a few other frameworks. As a bonus, you get a nicer api in h3 to handle cookies.

[pi0]

For now, i think we can also expose it from cookie-es. It was initially for compatibility but seems the API is also not that nice and could be better. PR is welcome 👍🏼

[tobiasdiez]

Makes sense. I don't have the time right now, but added it to unjs/h3#509 and unjs/cookie-es#17 so we keep track of it.

[pi0]

Perfect! Thanks for creating issues.