Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): support alwaysdata hosting provider #1790

Merged
merged 6 commits into from Feb 27, 2024

Conversation

m4dz
Copy link
Contributor

@m4dz m4dz commented Oct 5, 2023

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

alwaysdata is a French web hosting company supporting a large range of languages and frameworks such as Node.js and Nitro. This PR adds a preset and deployment documentation page dedicated to this provider.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Oct 5, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview c608bbc

docs/content/2.deploy/providers/alwaysdata.md Outdated Show resolved Hide resolved
docs/content/2.deploy/providers/alwaysdata.md Outdated Show resolved Hide resolved
2. [Upload your app](https://help.alwaysdata.com/en/remote-access/) to your account in its own directory (e.g. `$HOME/www/my-app`).

3. On your admin panel, [create a new site](https://admin.alwaysdata.com/site/add/) for your app with the following features:
- *Addresses*: `[account-name].alwaysdata.net`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems starting free plan setup, i need to update only account and cannot create new domain like nitro.alwaysdata.net it gives "domain does not belongs to you" error.

Should it be "edit exciting domain" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. It's not limited to the free tier: all plans at alwaysdata come with a default URL in the form of [account_name].alwaysdata.net. But you can create as many accounts as you want, and you can also link your own domains (or register new ones). So unless your account name is nitro, you can't use it as your URL.
I've added a section in the Create account pre-requisites to make it clearer. Does it sound good?

docs/content/2.deploy/providers/alwaysdata.md Outdated Show resolved Hide resolved
src/presets/alwaysdata.ts Outdated Show resolved Hide resolved
3. On your admin panel, [create a new site](https://admin.alwaysdata.com/site/add/) for your app with the following features:
- *Addresses*: `[account-name].alwaysdata.net`
- *Type*: Node.js
- *Command*: `node ./output/server/index.mjs`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no instructions how to upload website but it is .output by default i expect directories inside it (public/server) being copied to the hosting

Copy link
Contributor Author

@m4dz m4dz Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, I added a mention in the 2. above to add clarity on how deploying, for example using SSH. Do you think it's enough?

@pi0 pi0 marked this pull request as draft October 5, 2023 14:55
@pi0
Copy link
Member

pi0 commented Oct 5, 2023

Thanks for pull request dear @m4dz. I have made it WIP until we can solve all issues and have a successful deployment from the instructions.

@pi0 pi0 added the preset label Oct 5, 2023
@m4dz m4dz force-pushed the docs/alwaysdata branch 2 times, most recently from 10ef823 to 88df145 Compare October 5, 2023 17:25
@m4dz
Copy link
Contributor Author

m4dz commented Oct 5, 2023

Thanks @pi0 for the fast review! I made some changes, please tell me if it sounds good now πŸ‘

@m4dz
Copy link
Contributor Author

m4dz commented Oct 5, 2023

Added commands.deploy directive, should be better now :)

src/presets/alwaysdata.ts Outdated Show resolved Hide resolved
@m4dz m4dz marked this pull request as ready for review October 9, 2023 14:17
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry got delayed

@pi0 pi0 merged commit 0fa67c7 into unjs:main Feb 27, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
@m4dz
Copy link
Contributor Author

m4dz commented Feb 28, 2024

No worries, thanks a lot for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants