Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update reponse type check #1839

Merged
merged 2 commits into from
Oct 18, 2023
Merged

test: update reponse type check #1839

merged 2 commits into from
Oct 18, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 18, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Node.js introduced a breaking behavior change by renaming Response constrocutor name to _Response. Seems undici code is intact and a build tool chain issue! (~> nodejs/undici#2358)

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title try disabling shell-emulator chore: fix ci Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1839 (f8e9c69) into main (805eb7f) will increase coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    nodejs/node#1839      +/-   ##
==========================================
+ Coverage   52.31%   52.37%   +0.06%     
==========================================
  Files         170      170              
  Lines       11768    11772       +4     
  Branches      902      907       +5     
==========================================
+ Hits         6156     6166      +10     
+ Misses       5515     5510       -5     
+ Partials       97       96       -1     
Files Coverage Ξ”
src/storage.ts 52.27% <75.00%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

@pi0 pi0 marked this pull request as ready for review October 18, 2023 20:05
@pi0 pi0 changed the title chore: fix ci test: update reponse type check Oct 18, 2023
@pi0 pi0 merged commit df54c1c into main Oct 18, 2023
9 checks passed
@pi0 pi0 deleted the chore/fixci branch October 18, 2023 20:05
@pi0 pi0 mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant