Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursively simplify returned objects #1847

Merged
merged 2 commits into from
Oct 21, 2023
Merged

fix: recursively simplify returned objects #1847

merged 2 commits into from
Oct 21, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #1845 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is largely a DX improvement, but we should check that it doesn't have a significant performance cost when used.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working types labels Oct 21, 2023
@danielroe danielroe requested a review from pi0 October 21, 2023 19:50
@danielroe danielroe self-assigned this Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1847 (e7a4054) into main (3611071) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1847   +/-   ##
=======================================
  Coverage   52.35%   52.35%           
=======================================
  Files         170      170           
  Lines       11777    11777           
  Branches      905      907    +2     
=======================================
  Hits         6166     6166           
  Misses       5515     5515           
  Partials       96       96           
Files Coverage Ξ”
src/types/serialize.ts 100.00% <100.00%> (ΓΈ)

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks for this! Let's try it on nightly and plan for next minor if all good to you!

@pi0 pi0 merged commit e37359c into main Oct 21, 2023
9 checks passed
@pi0 pi0 deleted the fix/recursive-simplify branch October 21, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify type not handling nested objects correctly
2 participants