Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): fix etag and last-modified values #1855

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(cache): fix etag and last-modified values #1855

merged 1 commit into from
Oct 25, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 25, 2023

πŸ”— Linked issue

resolves #1850

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This fixes default values to be applied before normalizing header types to string

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1855 (7250f71) into main (e37359c) will decrease coverage by 0.24%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
- Coverage   52.35%   52.12%   -0.24%     
==========================================
  Files         170      170              
  Lines       11777    11780       +3     
  Branches      907      901       -6     
==========================================
- Hits         6166     6140      -26     
- Misses       5515     5544      +29     
  Partials       96       96              
Files Coverage Ξ”
src/runtime/cache.ts 0.00% <0.00%> (ΓΈ)

... and 2 files with indirect coverage changes

@pi0 pi0 merged commit df58288 into main Oct 25, 2023
6 of 9 checks passed
@pi0 pi0 deleted the fix/cache-headers branch October 25, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined cache headers
1 participant