Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(netlify): add note to make sure publish dist is set to dist #2035

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

Barbapapazes
Copy link
Member

πŸ”— Linked issue

fix #2032

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Update the documentation to warn users to update the publish directory to dist when using Netlify.

By default, Netlify will use .nuxt/dist which is not correct and this will break the deployment.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Dec 27, 2023
@Barbapapazes Barbapapazes self-assigned this Dec 27, 2023
Copy link
Contributor

nuxt-studio bot commented Dec 27, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview fac6dc2

@pi0
Copy link
Member

pi0 commented Dec 27, 2023

Default is correctly dist for Nitro projects:

image

@pi0 pi0 changed the title docs: warn user to update publish directory when deploying on netlify docs(netlify): add note to make sure publish dist is set to dist Dec 27, 2023
@pi0 pi0 merged commit ef8fccf into main Dec 27, 2023
4 of 5 checks passed
@pi0 pi0 deleted the docs/netlify-edge branch December 27, 2023 11:13
@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify edge preset does not upload public directory
2 participants