Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add baseURL to openapi generated url #2049

Merged
merged 2 commits into from Jan 4, 2024
Merged

fix: add baseURL to openapi generated url #2049

merged 2 commits into from Jan 4, 2024

Conversation

mcremer-able
Copy link
Contributor

πŸ”— Linked issue

I just found it and fixed it directly

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The servers property of the generated openAPI spec doesnt taske the baseURL property in the nitro config into account.
This change fixes that.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: Add missing base path to openApi spec fix: add baseURL to openapi generated url Jan 4, 2024
@pi0 pi0 merged commit 1e8910d into unjs:main Jan 4, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Jan 4, 2024

Thanks!

@pi0 pi0 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants