Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-pages): write _headers and _redirects #2290

Merged
merged 1 commit into from Mar 22, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 21, 2024

πŸ”— Linked issue

(context: reported in solid discord channel)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR enables writing _headers and _redirects file for cloudflare pages (non static). This resolves respecting header rules but also allows leveraging more CDN native primitives.

Example _headers:

/rules/headers
  cache-control: s-maxage=60
/rules/cors
  access-control-allow-origin: *
  access-control-allow-methods: GET
  access-control-allow-headers: *
  access-control-max-age: 0
/rules/nested/*
  x-test: test
/build/*
  cache-control: public, max-age=3600, immutable

Example _redirects

/rules/nested/override	/other	307
/rules/redirect/wildcard/*	https://nitro.unjs.io/**	307
/rules/redirect/obj	https://nitro.unjs.io/	308
/rules/nested/*	/base	307
/rules/redirect	/base	307

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe March 21, 2024 19:18
@pi0 pi0 changed the title fix(cloudflare-pages): write _headers and _redirects for non static builds fix(cloudflare-pages): write _headers and _redirects Mar 21, 2024
@pi0 pi0 merged commit e79858d into main Mar 22, 2024
5 checks passed
@pi0 pi0 deleted the fix/cf-pages-headers branch March 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants