feat(cache): allow setting custom getKey for defineCachedEventHandler
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Dec 12, 2022
src/runtime/cache.ts
Outdated
| getKey: | ||
| opts.getKey || | ||
| ((event) => { | ||
| const url = event.req.originalUrl || event.req.url; |
There was a problem hiding this comment.
Maybe we can call getKey inside this function? this way if it returns null, we can fallback to the default key behavior.
We also need to escape invalid chars also in all conditions (including ..) as they can lead to security issues.
There was a problem hiding this comment.
Yes, I think it makes sense to call it inside and fallback to the default; as for the escaping of invalid chars, do you mean escaping them from the returned key?
There was a problem hiding this comment.
Yes, to only allow ascii charachters like later regex we have.
yassilah
commented
Dec 13, 2022
| @@ -142,11 +146,9 @@ export function defineCachedEventHandler<T = any>( | |||
| ...opts, | |||
| getKey: (event) => { | |||
| const key = opts.getKey?.(event) | |||
| if (key) { return key } | |||
| if (key) { return escapeKey(key) } | |||
pi0
approved these changes
Dec 23, 2022
pi0
changed the title
getKey for defineCachedEventHandler
|
Thanks <3 |
|
thank you, now I can't wait to get back to work next year and remove all my disgusting hacks, lmao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #691
❓ Type of change
📚 Description
📝 Checklist