Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(netlify): use esm entrypoint #833

Merged
merged 3 commits into from
Jan 13, 2023
Merged

feat(netlify): use esm entrypoint #833

merged 3 commits into from
Jan 13, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We can now use native ESM in Netlify with this undocumented config option (cc: @ascorbic), see https://github.com/sveltejs/kit/blob/master/packages/adapter-netlify/index.js#L163.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Jan 13, 2023
@danielroe danielroe self-assigned this Jan 13, 2023
@danielroe danielroe requested a review from pi0 January 13, 2023 13:31
@pi0 pi0 changed the title fix(netlify): use netlify native esm feat(netlify): use esm entrypoint Jan 13, 2023
@pi0
Copy link
Member

pi0 commented Jan 13, 2023

Can you please fix ci?

@pi0 pi0 merged commit c1df65e into main Jan 13, 2023
@pi0 pi0 deleted the fix/netlify-native-esm branch January 13, 2023 14:13
pi0 pushed a commit that referenced this pull request Jan 16, 2023
@danielroe @pi0
feat(netlify): use esm entrypoint (#833)
f001398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @pi0