Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide fallback values for undefined runtime config #907

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#18586

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This provides fallback values for undefined runtime config: nuxt/nuxt#18586 (review)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 3, 2023
@danielroe danielroe requested a review from pi0 February 3, 2023 23:21
@danielroe danielroe self-assigned this Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #907 (20c1d2c) into main (f7eed65) will increase coverage by 0.03%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   67.50%   67.53%   +0.03%     
==========================================
  Files          59       59              
  Lines        5866     5878      +12     
  Branches      637      641       +4     
==========================================
+ Hits         3960     3970      +10     
- Misses       1897     1899       +2     
  Partials        9        9              
Impacted Files Coverage Ξ”
src/utils/index.ts 54.22% <90.00%> (+1.34%) ⬆️
src/options.ts 88.88% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@pi0 pi0 merged commit 881a0ba into main Feb 4, 2023
@pi0 pi0 deleted the fix/fallback-config branch February 4, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants