Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): mount src and root as read-only by default #920

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 6, 2023

πŸ”— Linked issue

Resolves #918

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We mount src/ and root/ fs mounts during development for convinience and development features however it can be really dangrous to remove project source-code!! Using new unstorage readOnly option on both mounts. If it is proven that write operation is useful, we can switch to noClear to allow per key update.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 merged commit a459e1e into main Feb 6, 2023
@pi0 pi0 deleted the fix/ro-mount branch February 6, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useStorage().clear() delete the project files in dev mode
1 participant