feat(firebase): use nodejs 18 as default runtime #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s if specified in package.json.
pi0
reviewed
Feb 8, 2023
| let nodeVersion = "14"; | ||
| let nodeVersion = "18"; | ||
| const supportedNodeVersions = ["18", "16", "14", "12", "10"]; | ||
| // ^ See https://cloud.google.com/functions/docs/concepts/nodejs-runtime | ||
| try { | ||
| const currentNodeVersion = JSON.parse( | ||
| await readFile(join(nitro.options.rootDir, "package.json"), "utf8") | ||
| ).engines.node; |
There was a problem hiding this comment.
Related: engines.node could be like 18 || 14 too. We might parse it as array and choose first matching version.
pi0
changed the title
pi0
approved these changes
Feb 8, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #924
❓ Type of change
📚 Description
Node 18 is the current LTS version. It is the recommended cloud function runtime and is a prerequisite for Nuxt 3. This PR changes the default runtime from 14 to 18, and falls back to an older version if it is specified in the
enginesfield inpackage.json.📝 Checklist