refactor(externals): sort bundledDependencies keys in output package.json

[danielroe]

🔗 Linked issue

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This reduces change between two builds of the same package. It's quite a minor change but can help ensure reproducible nitro builds.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

Merging #967 (ab773dc) into main (8f76db8) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   67.34%   67.34%   -0.01%     
==========================================
  Files          60       60              
  Lines        6073     6072       -1     
  Branches      680      681       +1     
==========================================
- Hits         4090     4089       -1     
  Misses       1974     1974              
  Partials        9        9              

Impacted Files	Coverage Δ
src/rollup/plugins/externals-legacy.ts	6.80% <0.00%> (ø)
src/rollup/plugins/externals.ts	94.31% <100.00%> (-0.02%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[pi0]

Keys order are expected to remain as is from original package. Is there a more specific reason doing this?

[danielroe]

When I run the same build more than once, these keys are reordered, so this is not currently deterministic. That makes me think that they are not remaining as-is.

[pi0]

LGTM. Only note that we might probably drop bundledDependencies property it was mainly for debugging purposes but also to introduce new manifest file in top level .output containing timestamp of build time.

I wish knew more about initiatives behind this PR...

[danielroe]

I wish knew more about initiatives behind this PR...

I was debugging a bundle size diff for a renovate update PR and spotted the discrepancy.