Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render json errors for CORS requests #969

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: render json errors for CORS requests #969

merged 1 commit into from
Feb 21, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#19093

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As $fetch is setting Accept: */* we can't detect JSON request purely by content-type. I think sec-fetch-mode might allow us to make another smart guess - CORS requests should probably also be JSON.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 21, 2023
@danielroe danielroe self-assigned this Feb 21, 2023
@pi0 pi0 merged commit 71a6e9e into main Feb 21, 2023
@pi0 pi0 deleted the fix/cors-requests branch February 21, 2023 15:03
@pi0
Copy link
Member

pi0 commented Feb 21, 2023

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants