Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-pages): only allow 100 rules #973

Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix(cloudflare-pages): only allow 100 rules #973

merged 2 commits into from
Feb 22, 2023

Conversation

danielroe
Copy link
Member

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

CF only supports 100 rules, which includes the 'include' as well as the 'exclude' rule. Seems like this might have been lost in the refactor.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 22, 2023
@danielroe danielroe requested a review from pi0 February 22, 2023 08:54
@danielroe danielroe self-assigned this Feb 22, 2023
@pi0
Copy link
Member

pi0 commented Feb 22, 2023

Maybe we can minus the include length? (100-include)

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #973 (5c8800a) into main (ac8c863) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   67.78%   67.77%   -0.02%     
==========================================
  Files          60       60              
  Lines        6128     6128              
  Branches      689      689              
==========================================
- Hits         4154     4153       -1     
- Misses       1965     1966       +1     
  Partials        9        9              
Impacted Files Coverage Ξ”
src/presets/cloudflare.ts 87.17% <100.00%> (-0.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 05839c4 into main Feb 22, 2023
@pi0 pi0 deleted the fix/route-length branch February 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants