Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scan middleware and print tree list in ascending alphabetical order #981

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#19234

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

While not exactly a bug, I think it makes sense to scan middleware in alphabetical order rather than the reverse, and also print the generated files that way too.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 23, 2023
@danielroe danielroe requested a review from pi0 February 23, 2023 06:01
@danielroe danielroe self-assigned this Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #981 (b11c218) into main (4585ca8) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files          60       60           
  Lines        6132     6132           
  Branches      691      691           
=======================================
  Hits         4157     4157           
  Misses       1966     1966           
  Partials        9        9           
Impacted Files Coverage Ξ”
src/utils/tree.ts 12.12% <0.00%> (ΓΈ)
src/scan.ts 72.72% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe changed the title fix: sort A-Z, not Z-A fix: scan middleware and print tree list in ascending alphabetical order Feb 23, 2023
@pi0 pi0 merged commit 44284ed into main Feb 28, 2023
@pi0 pi0 deleted the fix/asc-sort branch February 28, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants