Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only mock debug in production #990

Merged
merged 1 commit into from
Feb 24, 2023
Merged

fix: only mock debug in production #990

merged 1 commit into from
Feb 24, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#19236

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This moves our mock for debug out of default settings and is now only applied in production mode.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Feb 24, 2023
@danielroe danielroe requested a review from pi0 February 24, 2023 11:42
@danielroe danielroe self-assigned this Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #990 (dcfeec7) into main (5604ca3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files          60       60           
  Lines        6132     6133    +1     
  Branches      691      692    +1     
=======================================
+ Hits         4157     4158    +1     
  Misses       1966     1966           
  Partials        9        9           
Impacted Files Coverage Ξ”
src/rollup/config.ts 88.32% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit e08a8e9 into main Feb 24, 2023
@pi0 pi0 deleted the fix/dev-debug branch February 24, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants