Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support responseType: 'stream' as ReadableStream #100

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

okxiaoliang4
Copy link
Contributor

close: #99

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #100 (a58c8c5) into main (fde55ba) will increase coverage by 0.05%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   85.47%   85.53%   +0.05%     
==========================================
  Files           5        5              
  Lines         303      311       +8     
  Branches       60       60              
==========================================
+ Hits          259      266       +7     
- Misses         44       45       +1     
Impacted Files Coverage Δ
src/fetch.ts 86.88% <50.00%> (-0.41%) ⬇️
src/utils.ts 87.87% <100.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I've added a small change to automatically use stream with application/octet-stream content-type

@pi0 pi0 changed the title feat: responseType supported ReadableStream feat: support responseType: 'stream' as ReadableStream Sep 19, 2022
@pi0 pi0 merged commit 5a19f73 into unjs:main Sep 19, 2022
@okxiaoliang4 okxiaoliang4 deleted the feature/responseType-stream branch September 19, 2022 17:32
@Nomango Nomango mentioned this pull request Feb 28, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response.body.getReader error
2 participants