fix: improve error message for request errors #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just added 1 more commit now which will still output the request URL if there was no response in brackets. Again, this is useful if the browser intercepted the response, the internet disconnects and such. The error message will still have the useful information about the endpoint that was trying to be fetched. |
pi0
changed the title
pi0
changed the title
|
Most welcome @pi0 thanks for your work on OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message itself looks erroneous when the fetch fails without any request or response. Usually a network error. This can happen when a user disconnects from the internet or a fetch endpoint has an invalid ssl certfiicate.
Previously the message would be
Failed to Fetch ()with these empty brackets.Simple refactor to build the message up in the order that the final string will be and include the brackets only if required.
Thanks for all your work on this project! It's great.