Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize process.cwd on windows #31

Merged
merged 4 commits into from Aug 1, 2022
Merged

fix: normalize process.cwd on windows #31

merged 4 commits into from Aug 1, 2022

Conversation

danielroe
Copy link
Member

resolves #30

@danielroe danielroe added the bug Something isn't working label Aug 1, 2022
@danielroe danielroe requested a review from pi0 August 1, 2022 09:50
@danielroe danielroe self-assigned this Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #31 (7b786d9) into main (d429aa2) will increase coverage by 0.41%.
The diff coverage is 0.00%.

❗ Current head 7b786d9 differs from pull request most recent head b371f9f. Consider uploading reports for the commit b371f9f to get more accurate results

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   60.00%   60.41%   +0.41%     
==========================================
  Files           3        3              
  Lines         240      240              
  Branches       81       80       -1     
==========================================
+ Hits          144      145       +1     
  Misses         18       18              
+ Partials       78       77       -1     
Impacted Files Coverage Δ
src/path.ts 60.77% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d429aa2...b371f9f. Read the comment docs.

src/path.ts Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit a7b0f7b into main Aug 1, 2022
@pi0 pi0 deleted the fix/relative-windows branch August 1, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistant path.relative result
2 participants