fix(toRouteMatcher): respect non strict trailing slash #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves #87
β Type of change
π Description
When creating router with default options, we loose the trailing slash status as it is non strict by default.
toRouteMatcher
when extending router should respect same options and when matching routes.Note: This does not include
strictTrailingSlash
in the export object but by default we assume to have consistent default behavior (not sensitive to trailing slashes). For v2, we might include it in export object maybe with an_*
key if needed. /cc @danielroeπ Checklist