Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toRouteMatcher): respect non strict trailing slash #91

Merged
merged 3 commits into from Mar 8, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 8, 2024

πŸ”— Linked issue

resolves #87

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When creating router with default options, we loose the trailing slash status as it is non strict by default.

toRouteMatcher when extending router should respect same options and when matching routes.

Note: This does not include strictTrailingSlash in the export object but by default we assume to have consistent default behavior (not sensitive to trailing slashes). For v2, we might include it in export object maybe with an _* key if needed. /cc @danielroe

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe March 8, 2024 20:08
@pi0 pi0 added v1 bug Something isn't working labels Mar 8, 2024
@pi0 pi0 merged commit b731a53 into v1 Mar 8, 2024
1 check passed
@pi0 pi0 deleted the fix/matcher-slash branch March 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route matcher is always strict about trailing slashes
1 participant