Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clarify runtimes and isNode behavior #108

Merged
merged 10 commits into from Dec 22, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 22, 2023

πŸ”— Linked issue

closes #100

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (3250631) 80.63% compared to head (381069c) 82.50%.

❗ Current head 381069c differs from pull request most recent head bec505d. Consider uploading reports for the commit bec505d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   80.63%   82.50%   +1.87%     
==========================================
  Files          10       10              
  Lines         346      383      +37     
  Branches       32       32              
==========================================
+ Hits          279      316      +37     
  Misses         61       61              
  Partials        6        6              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title docs: clarify isNode flag behavior refactor: clarify runtimes and isNode behavior Dec 22, 2023
@pi0 pi0 merged commit d57a5d8 into main Dec 22, 2023
2 checks passed
@pi0 pi0 deleted the docs/is-flag-clarify branch December 22, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using package in Bun or in Deno with npm: specifier reports isNode as true
1 participant