fix: stringify protocol-relative URLs (#207)

unjs · Feb 5, 2024 · 3cd8c3f · 3cd8c3f
1 parent 21e644e
commit 3cd8c3f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/parse.ts b/src/parse.ts
@@ -1,5 +1,6 @@
 import { decode } from "./encoding";
 import { hasProtocol } from "./utils";
+const protocolRelative = Symbol.for("ufo:protocolRelative");
 export interface ParsedURL {
   protocol?: string;
   host?: string;
@@ -8,6 +9,7 @@ export interface ParsedURL {
   pathname: string;
   hash: string;
   search: string;
+  [protocolRelative]?: boolean;
 }
 
 export interface ParsedAuth {
@@ -64,6 +66,7 @@ export function parseURL(input = "", defaultProto?: string): ParsedURL {
     pathname,
     search,
     hash,
+    [protocolRelative]: !protocol,
   };
 }
 
@@ -125,7 +128,10 @@ export function stringifyParsedURL(parsed: Partial<ParsedURL>): string {
   const hash = parsed.hash || "";
   const auth = parsed.auth ? parsed.auth + "@" : "";
   const host = parsed.host || "";
-  const proto = parsed.protocol ? parsed.protocol + "//" : "";
+  const proto =
+    parsed.protocol || parsed[protocolRelative]
+      ? (parsed.protocol || "") + "//"
+      : "";
   return proto + auth + host + pathname + search + hash;
 }
 

diff --git a/test/parse.test.ts b/test/parse.test.ts
@@ -167,7 +167,7 @@ describe("parseURL", () => {
 
   for (const t of tests) {
     test(t.input.toString(), () => {
-      expect(parseURL(t.input)).toEqual(t.out);
+      expect(JSON.parse(JSON.stringify(parseURL(t.input)))).toEqual(t.out);
     });
   }
 });

diff --git a/test/utilities.test.ts b/test/utilities.test.ts
@@ -97,6 +97,7 @@ describe("stringifyParsedURL", () => {
     { input: "test?query=123#hash", out: "test?query=123#hash" },
     { input: "/%c", out: "/%c" },
     { input: "/%", out: "/%" },
+    { input: "//test.com", out: "//test.com" },
     {
       input: "http://foo.com/test?query=123#hash",
       out: "http://foo.com/test?query=123#hash",