host + port is recognised as protocol

[danielroe]

hasProtocol('localhost:3000')
// true

[pi0]

How do you think about solution? Technically something like mailto:3000@example.com is also valid protocol.

[divine]

Hello,

Probably the correct way of detecting protocols would be to get that from IANA list but the issue is that there are lot of unknown protocols.

https://en.m.wikipedia.org/wiki/List_of_URI_schemes

URL.protocol returns localhost: as protocol as well.

Thanks!

[pi0]

Good point about URL behavior and known schemes @divine. But indeed we have lots of 3rd party and unlisted protocols. Let me add data: and node: to the list.

We could try to have a smart regex that detects host:port only inputs BTW. (Because ufo utils, accept more than URL possible values and special values like this are kinda allowed)

[shtse8]

How do you think about solution? Technically something like mailto:3000@example.com is also valid protocol.

this is valid urn protocol, but not uri, maybe we can allow user to specific uri or urn in hasProtocol options? Probably it's hard to do it in smart way.

tested with urijs (the largest uri package in npm), same issue found.

new URI('localhost:3000').protocol()
// 'localhost'

[pi0]

This kind of input is basically host (${hostname}:${port}) which we implicitly accept as valid input for various ufo utils. Sticking with a strict URL parser, it is true that behavior returns localhost as a scheme but this is kinda the DX point of ufo utils over using raw URL to allow more versatility on common inputs.