feat: decodeQueryValue and decode query params with support for space
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
commented
Feb 2, 2021
danielroe
added a commit
to nuxt/nuxt
that referenced
this pull request
Feb 2, 2021
* needs to be matched with unjs/ufo#11 * closes #8692, closes #8690
danielroe
added a commit
to nuxt/nuxt
that referenced
this pull request
Feb 2, 2021
* needs to be matched with unjs/ufo#11 * closes #8692, closes #8690
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 84.40% 84.89% +0.48%
==========================================
Files 7 7
Lines 186 192 +6
Branches 51 51
==========================================
+ Hits 157 163 +6
Misses 29 29
Continue to review full report at Codecov.
|
pi0
reviewed
Feb 2, 2021
pi0
changed the title
decodeQueryValue and decode query params with support for space
|
Released as 0.6.0 |
rajkadhi10
reviewed
Jun 13, 2023
| @@ -12,7 +17,7 @@ export function parseQuery (paramsStr: string = ''): QueryObject { | |||
| const s = (param.match(/([^=]+)=?(.*)/) || []) | |||
| if (s.length < 2) { continue } | |||
| const key = decode(s[1]) | |||
There was a problem hiding this comment.
What if key is having space? The space is replaced with + sign while encoding but on decode it doesn't replace back to space.
There was a problem hiding this comment.
Do you mind to make a PR adding test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.