Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test script protocols insensitively #180

Merged
merged 1 commit into from Sep 28, 2023
Merged

fix: test script protocols insensitively #180

merged 1 commit into from Sep 28, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This addresses an issue where something like 'javaScript:alert(document.domain)' would not register as a script protocol owing to case sensitivity.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 28, 2023
@danielroe danielroe requested a review from pi0 September 28, 2023 10:25
@danielroe danielroe self-assigned this Sep 28, 2023
@pi0 pi0 merged commit f437a3b into main Sep 28, 2023
2 checks passed
@danielroe danielroe deleted the fix/insenstive-script branch September 28, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants