Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(joinURL): handle segments with ../ #217

Merged
merged 6 commits into from
Mar 11, 2024
Merged

feat(joinURL): handle segments with ../ #217

merged 6 commits into from
Mar 11, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #37

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Was reminded of this while implementing nuxt/fonts#24 (because we are rendering /_nuxt/../_fonts/some-font.woff2 instead of just /_fonts/some-font.woff2. It would be nice to get these URLs rendering better, which I'd like before we move it out of the experimental flag.

Would welcome any thoughts on a better algorithm. πŸ™

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 11, 2024
@danielroe danielroe requested a review from pi0 March 11, 2024 00:37
@danielroe danielroe self-assigned this Mar 11, 2024
@pi0 pi0 changed the title fix(joinURL): handle segments with ../ feat(joinURL): handle segments with ../ Mar 11, 2024
test/join.test.ts Show resolved Hide resolved
@pi0 pi0 merged commit 66c24d2 into main Mar 11, 2024
2 checks passed
@pi0 pi0 deleted the fix/join-url-relative branch March 11, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle relative URLs for resolveURL
2 participants