Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read tsconfig.compilerOptions.target as the default target #263

Closed
wants to merge 1 commit into from

Conversation

kecrily
Copy link

@kecrily kecrily commented May 10, 2023

Respect tsconfig.compilerOptions.target

close #257

@pi0
Copy link
Member

pi0 commented Jul 18, 2023

Thanks for the pull request. I think we can introduce a shortcut to make esbuild target config easier but reading implicitly from tsconfig is not the best idea.

Also this is new default behavior from esbuild v18

https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0180

TypeScript's target no longer affects esbuild's target (evanw/esbuild#2628)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unbuild throw "Top-level await is not available in the configured target environment ("es2020") " error
2 participants