-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct dts generation for stub mode #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiangmoe
force-pushed
the
main
branch
3 times, most recently
from
September 14, 2023 06:28
799443b
to
cd91e98
Compare
xiaoxiangmoe
changed the title
fix: declaration compatible option
fix: declaration option
Sep 14, 2023
pi0
changed the title
fix: correct
fix: correct Oct 30, 2023
declaration
optiondeclaration
option behavior
i encounter this problem |
pi0
changed the title
fix: correct
fix: correct dts generation for stub mode
Jun 4, 2024
declaration
option behavior
Thanks for PR dear @xiaoxiangmoe and sorry for late merge. I've rebased it together with #371 to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
The document write:
The behavior of the
declaration
option is inconsistent with the documentation.'node16'
, it will also convert totrue
.false
, it may convert totrue
if we have types or typing field in package.json. see declaration not workΒ #313 (This is a reasonable requirement since we may use other tools to package .d.ts. Just use unbuild to package .js)So I create a bug fix for it.
π Checklist