Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vue template ComponentCustomProperties interface #126

Merged
merged 3 commits into from Oct 10, 2022
Merged

Conversation

qmhc
Copy link
Contributor

@qmhc qmhc commented Oct 7, 2022

Fix unplugin/unplugin-auto-import#263.

Currently will occur type errors when ComponentCustomProperties under @vue/runtime-core, I think we should follow the Vue documentation to define it.

@amir20
Copy link

amir20 commented Oct 8, 2022

Does this actually fix unplugin/unplugin-auto-import#263? I tried it and didn't seem so. Am I missing something?

@antfu
Copy link
Member

antfu commented Oct 9, 2022

Please update the snapshot

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #126 (396163b) into main (ae19451) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          21       21           
  Lines        1677     1677           
  Branches      248      248           
=======================================
  Hits         1650     1650           
  Misses         27       27           
Impacted Files Coverage Δ
src/addons/vue-template.ts 95.38% <100.00%> (ø)
test/vue-template.test.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@antfu antfu merged commit 726d12c into unjs:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE and vue-tsc errors in templates
3 participants