fix: strip query param from keys

unjs · Feb 8, 2023 · cc3ebb7 · cc3ebb7
1 parent 313628b
commit cc3ebb7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -41,7 +41,11 @@ export function normalizeKey(key?: string) {
   if (!key) {
     return "";
   }
-  return key.replace(/[/\\]/g, ":").replace(/:+/g, ":").replace(/^:|:$/g, "");
+  return key
+    .split("?")[0]
+    .replace(/[/\\]/g, ":")
+    .replace(/:+/g, ":")
+    .replace(/^:|:$/g, "");
 }
 
 export function joinKeys(...keys: string[]) {

diff --git a/test/drivers/utils.ts b/test/drivers/utils.ts
@@ -33,13 +33,15 @@ export function testDriver(opts: TestOptions) {
   it("setItem", async () => {
     await ctx.storage.setItem("s1:a", "test_data");
     await ctx.storage.setItem("s2:a", "test_data");
+    await ctx.storage.setItem("s3:a?q=1", "test_data");
     expect(await ctx.storage.hasItem("s1:a")).toBe(true);
     expect(await ctx.storage.getItem("s1:a")).toBe("test_data");
+    expect(await ctx.storage.getItem("s3:a?q=2")).toBe("test_data");
   });
 
   it("getKeys", async () => {
     expect(await ctx.storage.getKeys().then((k) => k.sort())).toMatchObject(
-      ["s1:a", "s2:a"].sort()
+      ["s1:a", "s2:a", "s3:a"].sort()
     );
     expect(await ctx.storage.getKeys("s1").then((k) => k.sort())).toMatchObject(
       ["s1:a"].sort()