Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically provide imports object using import map #11

Merged
merged 11 commits into from
Jan 4, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 4, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #10

This PR eliminates the need for users to directly pass import objects.

Using imports map, we directly guide rollup to bundle the imports object into the binding.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b06f6f3) 95.27% compared to head (59c24a2) 92.25%.

❗ Current head 59c24a2 differs from pull request most recent head 30ba936. Consider uploading reports for the commit 30ba936 to get more accurate results

Files Patch % Lines
src/plugin/runtime.ts 95.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   95.27%   92.25%   -3.02%     
==========================================
  Files           6        6              
  Lines         423      478      +55     
  Branches       48       51       +3     
==========================================
+ Hits          403      441      +38     
- Misses         19       36      +17     
  Partials        1        1              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 marked this pull request as ready for review January 4, 2024 12:42
@pi0 pi0 merged commit 4e2ae1a into main Jan 4, 2024
2 of 3 checks passed
@pi0 pi0 deleted the feat/imports-map branch January 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use import maps
1 participant